AaronPo/the-biergarten-app
1
0
Fork 0
mirror of https://github.com/aaronpo97/the-biergarten-app.git synced 2026-06-01 01:54:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

readability updates: remove magic numbers, update comments

Browse Source
This commit is contained in:
Aaron Po
2026-05-01 17:38:16 -04:00
parent 9051f55114
commit 91e18888fe
15 changed files with 68 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tooling/pipeline/includes/data_generation/mock_generator.h
View File

@@ -44,6 +44,13 @@ class MockGenerator final : public DataGenerator {
*/
static size_t DeterministicHash(const Location& location);
// Hash stride constants for deterministic distribution across fixed-size
// arrays. These coprime strides spread hash values uniformly without
// clustering, ensuring diverse output across different hash inputs.
static constexpr size_t kNounHashStride = 7;
static constexpr size_t kDescriptionHashStride = 13;
static constexpr size_t kBioHashStride = 11;
static constexpr std::array<std::string_view, 18> kBreweryAdjectives = {
"Craft", "Heritage", "Local", "Artisan", "Pioneer", "Golden",
"Modern", "Classic", "Summit", "Northern", "Riverstone", "Barrel",

1
tooling/pipeline/includes/services/sqlite_export_service.h
View File

@@ -42,7 +42,6 @@ class SqliteExportService final : public IExportService {
void InitializeSchema() const;
void PrepareStatements();
void RollbackAndCloseNoThrow() noexcept;
void FinalizeStatements() noexcept;
[[nodiscard]] std::filesystem::path BuildDatabasePath() const;
[[nodiscard]] static std::string BuildLocationKey(const Location& location);

1
tooling/pipeline/includes/services/sqlite_statement_helpers.h
View File

@@ -107,7 +107,6 @@ void StepStatement(const SqliteDatabaseHandle& db_handle,
sqlite3_int64 LastInsertRowId(const SqliteDatabaseHandle& db_handle);
std::string SerializeLocalLanguages(const std::vector<std::string>& local_languages);
std::string SerializeVector(const std::vector<std::string>& str_vec);
} // namespace sqlite_export_service_internal