mirror of
https://github.com/aaronpo97/the-biergarten-app.git
synced 2026-10-15 01:54:43 +00:00
Fix C++ review findings in pipeline: k-prefixed enum values, include ordering, populated validation error messages, conventional const notation, and endl replaced with newline
This commit is contained in:
@@ -191,9 +191,9 @@ struct SamplingOptions {
|
||||
* @brief Selects which DataGenerator backend the pipeline uses.
|
||||
*/
|
||||
enum class GeneratorMode {
|
||||
Mock,
|
||||
Llama,
|
||||
OpenAI,
|
||||
kMock,
|
||||
kLlama,
|
||||
kOpenAI,
|
||||
};
|
||||
|
||||
/**
|
||||
@@ -202,25 +202,25 @@ enum class GeneratorMode {
|
||||
struct GeneratorOptions {
|
||||
/**
|
||||
* @brief Path to the LLM model file (gguf format). Only meaningful for
|
||||
* GeneratorMode::Llama.
|
||||
* GeneratorMode::kLlama.
|
||||
*/
|
||||
std::filesystem::path model_path;
|
||||
|
||||
/**
|
||||
* @brief Which generator backend to use.
|
||||
*/
|
||||
GeneratorMode mode = GeneratorMode::Mock;
|
||||
GeneratorMode mode = GeneratorMode::kMock;
|
||||
|
||||
/**
|
||||
* @brief Specific sampling parameters for this generator. Only
|
||||
* meaningful for GeneratorMode::Llama; if nullopt, LlamaGenerator uses
|
||||
* meaningful for GeneratorMode::kLlama; if nullopt, LlamaGenerator uses
|
||||
* its own defaults.
|
||||
*/
|
||||
std::optional<SamplingOptions> sampling;
|
||||
|
||||
/**
|
||||
* @brief OpenAI API key, read from the OPENAI_API_KEY environment
|
||||
* variable. Only populated for GeneratorMode::OpenAI.
|
||||
* variable. Only populated for GeneratorMode::kOpenAI.
|
||||
*/
|
||||
std::string openai_api_key;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user