Fix code analysis warnings

web/backend/Features/Features.Auth.Tests/Services/TokenServiceValidationTests.cs

@@ -11,14 +11,12 @@ namespace Features.Auth.Tests.Services;
 
 public class TokenServiceValidationTests
 {
-    private readonly Mock<IAuthRepository> _authRepositoryMock;
     private readonly Mock<ITokenInfrastructure> _tokenInfraMock;
     private readonly TokenService _tokenService;
 
     public TokenServiceValidationTests()
     {
         _tokenInfraMock = new Mock<ITokenInfrastructure>();
-        _authRepositoryMock = new Mock<IAuthRepository>();
 
         // Set environment variables for tokens
         Environment.SetEnvironmentVariable(
@@ -34,7 +32,7 @@ public class TokenServiceValidationTests
             "test-confirmation-secret-that-is-very-long-1234567890"
         );
 
-        _tokenService = new TokenService(_tokenInfraMock.Object, _authRepositoryMock.Object);
+        _tokenService = new TokenService(_tokenInfraMock.Object, new Mock<IAuthRepository>().Object);
     }
 
     [Fact]

web/backend/Features/Features.Auth/Repository/AuthRepository.cs

@@ -2,7 +2,6 @@ using System.Data.Common;
 using Dapper;
 using Domain.Entities;
 using Domain.Exceptions;
-using Features.Auth.Dtos;
 using Infrastructure.Sql;
 using Microsoft.Data.SqlClient;
 
@@ -46,7 +45,7 @@ public class AuthRepository(ISqlConnectionFactory connectionFactory)
                     INSERT INTO dbo.UserCredential (UserAccountId, Hash)
                     VALUES (@UserAccountId, @Hash);
                     """,
-                    new { UserAccountId = userAccountId, Hash = ua.UserCredential?.Hash },
+                    new { UserAccountId = userAccountId, ua.UserCredential?.Hash },
                     transaction
                 )
             );

web/backend/Features/Features.Auth/Repository/IAuthRepository.cs

@@ -1,5 +1,4 @@
 using Domain.Entities;
-using Features.Auth.Dtos;
 
 namespace Features.Auth.Repository;
 

web/backend/Features/Features.Auth/Services/ITokenService.cs

@@ -62,10 +62,6 @@ public interface ITokenService
     /// </summary>
     string GenerateConfirmationToken(UserAccount user);
 
-    /// <summary>Generates a token of the type specified by <typeparamref name="T" />.</summary>
-    /// <typeparam name="T">Must be <see cref="TokenType" />.</typeparam>
-    string GenerateToken<T>(UserAccount user)
-        where T : struct, Enum;
 
     /// <summary>Validates an access token's signature and expiration and extracts the caller's identity.</summary>
     /// <exception cref="Domain.Exceptions.UnauthorizedException">

web/backend/Features/Features.Auth/Services/TokenService.cs

@@ -88,30 +88,6 @@ public class TokenService : ITokenService
         );
     }
 
-    /// <inheritdoc />
-    /// <exception cref="InvalidOperationException">
-    ///     Thrown when <typeparamref name="T" /> is not <see cref="TokenType" /> or does not resolve to a known token type.
-    /// </exception>
-    public string GenerateToken<T>(UserAccount user)
-        where T : struct, Enum
-    {
-        if (typeof(T) != typeof(TokenType))
-            throw new InvalidOperationException("Invalid token type");
-
-        string tokenTypeName = typeof(T).Name;
-        if (!Enum.TryParse(typeof(TokenType), tokenTypeName, out object? parsed))
-            throw new InvalidOperationException("Invalid token type");
-
-        TokenType tokenType = (TokenType)parsed;
-        return tokenType switch
-        {
-            TokenType.AccessToken => GenerateAccessToken(user),
-            TokenType.RefreshToken => GenerateRefreshToken(user),
-            TokenType.ConfirmationToken => GenerateConfirmationToken(user),
-            _ => throw new InvalidOperationException("Invalid token type"),
-        };
-    }
-
     /// <inheritdoc />
     public async Task<ValidatedToken> ValidateAccessTokenAsync(string token)
     {

web/backend/Features/Features.Breweries.Tests/Queries/GetBreweryByIdHandlerTests.cs

@@ -29,7 +29,7 @@ public class GetBreweryByIdHandlerTests
         );
 
         result.Should().NotBeNull();
-        result!.BreweryPostId.Should().Be(brewery.BreweryPostId);
+        result.BreweryPostId.Should().Be(brewery.BreweryPostId);
     }
 
     [Fact]

web/backend/Features/Features.Breweries/Commands/CreateBrewery/CreateBreweryValidator.cs

@@ -25,7 +25,6 @@ public class CreateBreweryValidator : AbstractValidator<CreateBreweryCommand>
 
         RuleFor(x => x.Location.CityId)
             .NotEmpty()
-            .When(x => x.Location is not null)
             .WithMessage("CityId is required.");
 
         RuleFor(x => x.Location.AddressLine1)
@@ -33,15 +32,12 @@ public class CreateBreweryValidator : AbstractValidator<CreateBreweryCommand>
             .When(x => x.Location is not null)
             .WithMessage("Address line 1 is required.")
             .MaximumLength(256)
-            .When(x => x.Location is not null)
             .WithMessage("Address line 1 cannot exceed 256 characters.");
 
         RuleFor(x => x.Location.PostalCode)
             .NotEmpty()
-            .When(x => x.Location is not null)
             .WithMessage("Postal code is required.")
             .MaximumLength(20)
-            .When(x => x.Location is not null)
             .WithMessage("Postal code cannot exceed 20 characters.");
     }
 }

web/backend/Features/Features.Breweries/Dtos/BreweryDtoMapper.cs

@@ -27,11 +27,11 @@ public static class BreweryDtoMapper
                     CityName: brewery.Location.City?.CityName ?? string.Empty,
                     StateProvinceName: brewery.Location.City?.StateProvince?.StateProvinceName
                         ?? string.Empty,
-                    StateProvinceCode: brewery.Location.City?.StateProvince?.ISO3166_2
+                    StateProvinceCode: brewery.Location.City?.StateProvince?.Iso31662
                         ?? string.Empty,
                     CountryName: brewery.Location.City?.StateProvince?.Country?.CountryName
                         ?? string.Empty,
-                    CountryCode: brewery.Location.City?.StateProvince?.Country?.ISO3166_1
+                    CountryCode: brewery.Location.City?.StateProvince?.Country?.Iso31661
                         ?? string.Empty,
                     AddressLine1: brewery.Location.AddressLine1,
                     AddressLine2: brewery.Location.AddressLine2,

web/backend/Features/Features.Emails/Services/EmailDispatcher.cs

@@ -36,7 +36,7 @@ public class EmailDispatcher(
             confirmationLink
         );
 
-        await emailProvider.SendAsync(email, "Welcome to The Biergarten App!", emailHtml, true);
+        await emailProvider.SendAsync(email, "Welcome to The Biergarten App!", emailHtml);
     }
 
     /// <inheritdoc />

web/backend/Features/Features.UserManagement/Repository/UserAccountRepository.cs

@@ -59,7 +59,7 @@ public class UserAccountRepository(ISqlConnectionFactory connectionFactory)
             """,
             new
             {
-                UserAccountId = userAccount.UserAccountId,
+                userAccount.UserAccountId,
                 userAccount.Username,
                 userAccount.FirstName,
                 userAccount.LastName,